Add more unit tests for aggregator #878
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This new unit test is failing even though it shouldn't be.
Why does this test get 500/500 signature weight? Shouldn't it the child context be canceled by VerifyWeight after we hit 300/500 or 60/100 and therefore we shouldn't be able to fetch more signatures?''
Edit: Spun up 100 go routines.
signatureFetchCancel(), aka the child ctx gets called exactly right. cancel propagates down to `fetchSignature and gets BLS signatures for about 80 go routines and the rest get handled by ctx.Done(). This makes me think we will fetch signatures from every node, even if a cancel triggers.#881 this should help the overfetching
How this works
How this was tested
How is this documented